Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality configuration for Codeac.io #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

michal-simon
Copy link

Hello Marcelo,
I briefly looked up your repo and saw a good amount of work you have done over here. Good job, man! 🥇

You recently also tried Codeac.io and you probably haven't had a good experience just because of lack of correct configuration and false positives.

I went through the biggest issues in your repository and added configuration to this pull-request to avoid irrelevant problems. I hope this will be helpful for you and find Codeac more useful after this.

Basically I ignored all external dependencies you have stored in the repository. This is just a workaround to help you get better results. The best practice would be to remove it from your repo completely and refer to it in package.json or composer.json instead.

Let me know if you need any more help.

Michal Šimon
CEO @ Codeac.io

PS: Keep doing open-source, please! We all appreciate your work a lot! :)

@michal-simon
Copy link
Author

Hi Marcelo, how are you doing? I just wanted to ask if you had a chance to look at this PR. Is there anything blocking the merge? Happy to fix it. :)
Best, Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant